arquillian / arquillian-testrunner-spock

Arquillian Spock TestRunner
Apache License 2.0
30 stars 20 forks source link

Spock 2.x support #119

Open Vampire opened 9 months ago

Vampire commented 9 months ago

The readme tells to use @RunWith(ArquillianSputnik.class). That means to me, this is not compatible with Spock 2.x which is not JUnit 4 based anymore. Spock 2.x is a JUnit 5 platform engine, so this modules most probably needs to be updated to be Spock 2.x compatible.

kriegaex commented 9 months ago

@bartoszmajsak (CC @aslakknutsen, if you are still active), I remember that even in old times (around 2015+), you rarely had time to maintain this project. Even from back then, there are two open issues my previous team and I were involved in. Can you make a statement about whether it makes more sense to wait for you to work on the project or to regard it as abandoned and either fork it, ask for write permissions here or create a new one?

Concerning this issue as such, instead of a JUnit runner, probably you want to convert this into a Spock extension, probably a global one. I am not sure if an annotation-driven extension would suffice, as I never really looked into the code. But given the fact that back then you chose to use a runner and not an extension, I would put my money on the global extension.

bartoszmajsak commented 9 months ago

@kriegaex I'm on PTO right now. I'll get back to you when I'm back on 23.10.

CianShev commented 1 month ago

Has there been any update on this or is this project not supporting Spock 2.x?