Updated guide for forge arquillian-core with all latest changes.

arquillian / arquillian.github.io

Arquillian website source (develop branch) and hosting (master branch). Baked with Awestruct.

http://arquillian.org

Other

78 stars 148 forks source link

Updated guide for forge arquillian-core with all latest changes. #373

Closed dipak-pawar closed 7 years ago

dipak-pawar commented 7 years ago

Short description of what this resolves:

Adds new documentation with forge2

lordofthejars commented 7 years ago

LGTM

bartoszmajsak commented 7 years ago

Few things here:

we have to mark other languages as draft: true so that they are not visible in prod profile, but in dev mode only - this way we can get contributions easier as ppl can work on the actual text.
we have to check if our "flag logic" (generate country flags pointing to translations) respect draft mode. if not we have to fix it

We shouldn't merge it before resolving it, as we will end up with inconsistent guides. I don't assume we can translate all the languages at once, that's why we should have draft mode.

MatousJobanek commented 7 years ago

we have to check if our "flag logic" (generate country flags pointing to translations) respect draft mode. if not we have to fix it

I'll check it

MatousJobanek commented 7 years ago

So I tried it and it works (with small modification). Here is PR with the fix and with a commit that labels the Forge guide translations as a draft. https://github.com/arquillian/arquillian.github.io/pull/379 I added also a warning there:

h1. WARNING: This guide is labeled as a draft (will be visible only in the development mode) as it is a translation of an older version of the "Get Started Faster with Forge" guide.

If you're fine with both PRs, I'll merge them and regenerate the blog.

bartoszmajsak commented 7 years ago

Great stuff, thanks a lot! Would it be hard to add this h1 on the fly?

MatousJobanek commented 7 years ago

I'm not sure how hard it would be, in any case, I don't think that it is a good idea. Reasons?:

The warning should contain why the page is labeled as a draft and there is no general reason applicable for all cases.
The warning should be visible also in the source code - not only when I run the blog in dev mode - when I go to the code a see that there is the translation, then I should also know why it is not visible on the web pages.
Anybody who labels a page as a draft, should also put the reason why (s)he did it

MatousJobanek commented 7 years ago

Landed in https://github.com/arquillian/arquillian.github.io/commit/3635c73e77564360c4144b321b9d1f6b2fa9e148 🚀 Thank you @dipak-pawar 🥇