search

arquillian / arquillian.github.io

Arquillian website source (develop branch) and hosting (master branch). Baked with Awestruct.
http://arquillian.org
Other
78 stars 147 forks source link

Add liberty-arquillian repository #437

Closed gpoul closed 6 years ago

gpoul commented 6 years ago

Addresses request from #436; not sure if anything is still missing.

MatousJobanek commented 6 years ago

Hi @gpoul, thanks a lot for the PR and for making the Arqullian family bigger :-).

I've noticed that you solved the problem with the lead and with registering it as a container component. Hovewer, there is still one thing that needs to be done to make it visible on the arquillian.org web pages - it is at least one release of the project. The reason is that all projects that don't contain any release are automatically omitted.

Second bit that would be good to have is a registration of the issue tracker - to list all issues fixed/implemented in the releases. If I'm not wrong, it should be sufficient to add this line: extension Awestruct::Extensions::Github::ReleaseNotes.new('OpenLiberty/liberty-arquillian', 'arquillian') into the pipeline.rb

Please, also update the PR with the latest changes from the develop branch as there was some problems with fetching data from confluence, so I added a workaround there.

gpoul commented 6 years ago

Thanks for your feedback! I'll look into that over the next few days. We don't have a release yet, but that will come for sure. But for me the modules page was generated just fine even as it is now; the main issue was that my docker on mac seems to be confused and not able to access the awestruct deamon so I needed to load the HTML manually from disk and didn't see any images.... but the HTML seemed fine.

On Mon, Apr 23, 2018 at 6:45 PM Matous Jobanek notifications@github.com wrote:

Hi @gpoul https://github.com/gpoul, thanks a lot for the PR and for making the Arqullian family bigger :-).

I've noticed that you solved the problem with the lead and with registering it as a container component. Hovewer, there is still one thing that needs to be done to make it visible on the arquillian.org web pages

  • it is at least one release of the project. The reason is that all projects that don't contain any release are automatically omitted.

Second bit that would be good to have is a registration of the issue tracker - to list all issues fixed/implemented in the releases. If I'm not wrong, it should be sufficient to add this line: extension Awestruct::Extensions::Github::ReleaseNotes.new('OpenLiberty/liberty-arquillian', 'arquillian') into the pipeline.rb https://github.com/arquillian/arquillian.github.io/blob/develop/_ext/pipeline.rb#L73

Please, also update the PR with the latest changes from the develop branch as there was some problems with fetching data from confluence, so I added a workaround there.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/arquillian/arquillian.github.io/pull/437#issuecomment-383643204, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJ3WrsaZUu7Hsdg80FQ1AHmlFgLMHF_ks5trgUNgaJpZM4Te_Kz .

MatousJobanek commented 6 years ago

ah, sure, you are right - the not-released repositories that are omitted are only those that are automatically fetched from arqullian organization - these "hard coded" are added to the modules page with the snapshot version. So sorry for confusions - I sometimes get lost in the whole generation process and its conditions and possibilities. From my side, the PR looks good. Thanks again for it!