search

arquillian / arquillian.github.io

Arquillian website source (develop branch) and hosting (master branch). Baked with Awestruct.
http://arquillian.org
Other
78 stars 147 forks source link

fix: docker build failures #447

Open baerrach opened 3 years ago

baerrach commented 3 years ago

Short description of what this resolves:

Docker builds fail as per arquillian/arquillian.github.io#446

Changes proposed in this pull request:

Remove workaround for rvm/issues/4068 as this issue was fixed in Aug 28, 2017, use proper rvm installer.

Awestruct 0.6.0 has since been released, use that version. Requires upgrading ruby.

Fixes: #

arquillian/arquillian.github.io#446

baerrach commented 3 years ago

The --net=host uses host networking, which means that the container lives in the host port space. Generally not what you want.

The problem is the awestruck binds to localhost by default, which isn't tunneled by docker. Instead it should be binding to the local ip assigned, or better yet just all interfaces 0.0.0.0 to save black magic commands to lookup the assigned ip (and the Dockerfile doesn't include net-tools so good luck with that).

awestruct --bind 0.0.0.0 -d

This allows me to connect to localhost:4242 and get results.

baerrach commented 3 years ago 
Puma caught this error: undefined method `[]' for nil:NilClass (NoMethodError)
/home/dev/arquillian.github.io/.gems/ruby/2.4.0/gems/awestruct-0.6.1/lib/awestruct/rack/generate.rb:19:in `call'
/home/dev/arquillian.github.io/.gems/ruby/2.4.0/gems/rack-2.2.3/lib/rack/builder.rb:244:in `call'
/home/dev/arquillian.github.io/.gems/ruby/2.4.0/gems/puma-5.0.0/lib/puma/configuration.rb:238:in `call'
/home/dev/arquillian.github.io/.gems/ruby/2.4.0/gems/puma-5.0.0/lib/puma/server.rb:620:in `handle_request'
/home/dev/arquillian.github.io/.gems/ruby/2.4.0/gems/puma-5.0.0/lib/puma/server.rb:377:in `process_client'
/home/dev/arquillian.github.io/.gems/ruby/2.4.0/gems/puma-5.0.0/lib/puma/server.rb:231:in `block in run'
/home/dev/arquillian.github.io/.gems/ruby/2.4.0/gems/puma-5.0.0/lib/puma/thread_pool.rb:141:in `block in spawn_thread'
/home/dev/arquillian.github.io/.gems/ruby/2.4.0/gems/logging-2.3.0/lib/logging/diagnostic_context.rb:474:in `block in create_with_logging_context'

Why is this so hard? I'm assuming there is a bug in awestruct, no changes to repo in 5 years...