search

arquillian / continuous-enterprise-development

Testable Solutions for Modern Applications
http://continuousdev.org/
116 stars 150 forks source link

Update REST Chapter to account for code changes #81

Closed ALRubinger closed 10 years ago

ALRubinger commented 11 years ago

The following commit impacts the text in the REST Chapter:

a79d46f67b7b3277e47a05464ca5bdd6a50653b8

Update the prose to match. Alternatively, describe for me what's changed and I'll handle the update, but I need at least some descriptive info to go off. :)

aslakknutsen commented 11 years ago

The commit message + javadoc on RESTInterceptorEnabler is not enough?

ALRubinger commented 11 years ago

Beautiful, yes.

ALRubinger commented 11 years ago

Reassigning to me.

ALRubinger commented 11 years ago

Reassigning to @aslakknutsen to verify 35a49a5. Note: code changes are due to typo spelling correction.

ALRubinger commented 11 years ago

Ping for review/close @aslakknutsen

aslakknutsen commented 11 years ago

Added comments on the commit, reassign to @ALRubinger

aslakknutsen commented 11 years ago

Minor fixes pushed upstream.

One question remaining: https://github.com/arquillian/continuous-enterprise-development/commit/35a49a5d7b731e26c2aff1300c478ece7deadf8a#commitcomment-4115791 Do we keep it as is for simplicity or update it to sync with 'reality' ?

aslakknutsen commented 10 years ago

Agreed to leave as is for simplicity; https://github.com/arquillian/continuous-enterprise-development/commit/35a49a5d7b731e26c2aff1300c478ece7deadf8a#commitcomment-4863731

Closing