arquillian / smart-testing

We know which tests you want to run.
Apache License 2.0
25 stars 12 forks source link

feat(#301): Add support for Tag and Tags annotation from JUnit 5 #307

Closed lordofthejars closed 6 years ago

lordofthejars commented 6 years ago

Short description of what this resolves:

Add support for Tag and Tags annotation from JUnit 5

Changes proposed in this pull request:

Fixes #301

lordofthejars commented 6 years ago

Before merging I'll update the docs.

lordofthejars commented 6 years ago

@dipak-pawar I am not sure that adds any benefit adding a ftest for this use case. Notice that the change is internal, the logic is the same,the only difference is that now we are taking @Categories or @Tags but then the logic is exactly the same. And this extracting logic is fully covered with unit tests.

In my opinion adding a new ftest means adding extra 15 seconds on build which are not necessary at all for this case.