arquillian / smart-testing

We know which tests you want to run.
Apache License 2.0
25 stars 12 forks source link

Categorized exclusions #311

Closed spriadka closed 6 years ago

spriadka commented 6 years ago

Short description of what this resolves:

This PR implements the possibility to manually exclude test classes/methods from execution based on their category (see #310 )

Changes proposed in this pull request:

Fixes #

spriadka commented 6 years ago

@MatousJobanek WDYT?

MatousJobanek commented 6 years ago

Hi @spriadka thanks for your contribution and sorry for my long inactivity - I was knocked out by flu in last 8 days. I'll do the review today.

spriadka commented 6 years ago

Thanks for the feedback @MatousJobanek . Sorry for my long inactivity as well, I was not able to make until yesterday. I made some major changes e.g removed group imports, changed test logic, removed the CategorizedTestSelection class etc. However, I would like to stand by the IncludingCategoryFilter and ExcludingCategoryFilter as it seems more elegant way than passing a boolean parameter into a method.