Replay doesn't open with same language settings as the rest of the website

arquivo / pwa-technologies

Arquivo.pt main goal is the preservation and access of web contents that are no longer available online. During the developing of the PWA IR (information retrieval) system we faced limitations in searching speed, quality of results, scalability and usability. To cope with this, we modified the archive-access project (http://archive-access.sourceforge.net/) to support our web archive IR requirements. Nutchwax, Nutch and Wayback’s code were adapted to meet the requirements. Several optimizations were added, such as simplifications in the way document versions are searched and several bottlenecks were resolved. The PWA search engine is a public service at http://archive.pt and a research platform for web archiving. As it predecessor Nutch, it runs over Hadoop clusters for distributed computing following the map-reduce paradigm. Its major features include fast full-text search, URL search, phrase search, faceted search (date, format, site), and sorting by relevance and date. The PWA search engine is highly scalable and its architecture is flexible enough to enable the deployment of different configurations to respond to the different needs. Currently, it serves an archive collection searchable by full-text with 180 million documents ranging between 1996 and 2010.

http://www.arquivo.pt

GNU General Public License v3.0

38 stars 7 forks source link

Replay doesn't open with same language settings as the rest of the website #1315

Open VascoRatoFCCN opened 1 year ago

VascoRatoFCCN commented 1 year ago

go to arquivo.pt
change language to EN
search for a website (e.g.: fccn.pt)
choose any version from the list
the replay page is not in English, it's in Portuguese.

It's almost certainly caused by a bad setting of the language cookie.

VascoRatoFCCN commented 1 year ago

https://github.com/arquivo/pywb-arquivo/commit/d2ba9a6b761414c5789c9d6f25e5be08cc244eec fixes this

Had to do with language cookie not being read because it has "HttpOnly" set. Changed the template to read the cookie server-side.

VascoRatoFCCN commented 1 year ago

It still didn't solve the problem, sometimes the cookie simply isn't read for some reason

VascoRatoFCCN commented 1 year ago

Changed i18n cookie to not be httponly. Issue resolved with the following commits:

https://github.com/arquivo/pywb-arquivo/commit/eb5712002fd9e6909a5e3d47d24ac33a199b8221 https://github.com/arquivo/arquivo-webapp-eros/commit/ee5756afabacd44e6186b2b17423e71f2b6ba0d5