Closed ericzhang6222 closed 4 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
rel/expr_cond_pattern_control_var.go | 0 | 7 | 0.0% | ||
<!-- | Total: | 0 | 7 | 0.0% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
rel/value_set_generic.go | 2 | 74.47% | ||
rel/value_set_str.go | 4 | 59.65% | ||
<!-- | Total: | 6 | --> |
Totals | |
---|---|
Change from base Build a54e1484615ecec9b3d6388de844c50bdc328ee4: | -0.08% |
Covered Lines: | 4295 |
Relevant Lines: | 9024 |
As a follow up, raise an issue to fail for all unreachable cases. E.g., the first condition renders the third condition unreachable in the following code:
cond {
[x, ...]: x,
(:a): a,
[x, y]: x + y,
}
Close it, will rework and raise new PR in #484
@ericzhang6222 do you still need the branch?
@ericzhang6222 do you still need the branch?
I have removed branch.
Fixes #472 .
Changes proposed in this pull request:
Checklist: