Protobuf import changes - Githubissues

arr-ai / arrai

The ultimate data engine.

http://arr.ai

Apache License 2.0

20 stars 15 forks source link

Protobuf import changes #518

Closed ericzhang6222 closed 4 years ago

ericzhang6222 commented 4 years ago

Fixes #496 .

Changes proposed in this pull request:

There is some implementation can be discussed or changed still, but the API signature and flow changes are made sure and can be released.

Checklist:

[x] Added related tests
[x] Made corresponding changes to the documentation

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build fef56e085e44b584fadd95dff39b0305dc5fe37a-PR-518

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 47.764%

Files with Coverage Reduction	New Missed Lines	%
rel/value_set_str.go	2	60.82%
<!--	Total:	2		-->

Totals
Change from base Build a4bcbdaff62725d3c3fbe5794e85dbd1a4d6d444:	-0.04%
Covered Lines:	4379
Relevant Lines:	9168

💛 - Coveralls