Return the right error when accessing nonexistent empty tuple key - Githubissues

arr-ai / arrai

The ultimate data engine.

http://arr.ai

Apache License 2.0

20 stars 15 forks source link

Return the right error when accessing nonexistent empty tuple key #573

Closed orlade-anz closed 4 years ago

orlade-anz commented 4 years ago

Fixes #572.

Changes proposed in this pull request:

Add a length check for the attribute before slicing it.

Checklist:

[x] Added related tests
[ ] Made corresponding changes to the documentation

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build fea6224cc143d62cc2b4ad8fe04e603f668a905d-PR-573

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.3%) to 47.969%

Files with Coverage Reduction	New Missed Lines	%
rel/value_set_str.go	7	56.7%
<!--	Total:	7		-->

Totals
Change from base Build 81f302899df339eaefb70f32c77a7ef1c74fc67d:	0.3%
Covered Lines:	4558
Relevant Lines:	9502

💛 - Coveralls