arr-ai / arrai

The ultimate data engine.
http://arr.ai
Apache License 2.0
20 stars 15 forks source link

add context to all eval functions #590

Closed nofun97 closed 4 years ago

nofun97 commented 4 years ago

Part of #584

Changes proposed in this pull request:

The context var will be used to contain filesystem which can be used to compile arrai programs

note to reviewer: I put a few TODO and FIXME, please read those before approving

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build dbadf480b6e07bb7fa185e0d59cf637c6de202bf-PR-590


Changes Missing Coverage Covered Lines Changed/Added Lines %
rel/expr_if_else.go 4 5 80.0%
rel/expr_literal.go 0 1 0.0%
rel/pattern_extra_element.go 0 1 0.0%
rel/value_set_dict.go 0 1 0.0%
rel/value_set_func.go 0 1 0.0%
rel/value_set_native_func.go 0 1 0.0%
rel/value_tuple_dict_entry.go 0 1 0.0%
syntax/import.go 1 2 50.0%
rel/expr.go 1 3 33.33%
rel/expr_darrow.go 6 8 75.0%
<!-- Total: 54 243 22.22% -->
Files with Coverage Reduction New Missed Lines %
rel/value_set_eclosure.go 1 0%
rel/pattern_expr_pair.go 2 0%
rel/value_set_dict.go 3 43.36%
rel/test_helpers.go 18 56.69%
<!-- Total: 24 -->
Totals Coverage Status
Change from base Build 89fa6566954d545d94af009428cab301ca0abb31: 0.02%
Covered Lines: 4770
Relevant Lines: 9863

💛 - Coveralls
nofun97 commented 4 years ago

the function WrapContext is changed to WrapContextErr to avoid confusion