arr-ai / arrai

The ultimate data engine.
http://arr.ai
Apache License 2.0
20 stars 15 forks source link

allow nested import root and import root fixes #611

Closed nofun97 closed 4 years ago

nofun97 commented 4 years ago

This commit will allow nested root markers in a project. Root markers will be found by going up the source directory of a file. A root marker can be in the same directory or the parent directories. The root marker locations will also be cached for faster root marker lookup.

This commit also fixed the root marker lookup as initially it was done by searching from the provided import path instead of the directory location of the source scripts.

Checklist:

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build cdccbf3e6d8e18e0dfab5f46ff2f2f3a617ad25d-PR-611

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
syntax/import.go 10 11 90.91%
<!-- Total: 15 16 93.75% -->
Files with Coverage Reduction New Missed Lines %
rel/value_tuple.go 2 75.2%
syntax/import.go 11 79.63%
<!-- Total: 13 -->
Totals Coverage Status
Change from base Build 80ff43ddb790bc0927dbfc281d94c4b2755b5d25: 0.05%
Covered Lines: 4808
Relevant Lines: 9900

💛 - Coveralls