arr-ai / arrai

The ultimate data engine.
http://arr.ai
Apache License 2.0
20 stars 15 forks source link

Bundle #621

Closed nofun97 closed 4 years ago

nofun97 commented 4 years ago

Part of #584

Changes proposed in this pull request:

Checklist:

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 1fc827c203ccabacbe9b65263c85b27beb5a7e87-PR-621


Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/arrai/run.go 10 17 58.82%
syntax/import.go 5 12 41.67%
cmd/arrai/bundle.go 0 38 0.0%
<!-- Total: 15 67 22.39% -->
Files with Coverage Reduction New Missed Lines %
rel/value_set_str.go 4 57.87%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 087fde7bcfa6240bcfcd245ee9185f42324aa3cc: -0.8%
Covered Lines: 4855
Relevant Lines: 10262

💛 - Coveralls
orlade-anz commented 4 years ago

I don't understand most of this but it looks good!

nofun97 commented 4 years ago

I don't understand most of this but it looks good!

I should probably add a documentation then. Will add a design doc.

orlade-anz commented 4 years ago

I should probably add a documentation then. Will add a design doc.

I applaud your enthusiasm, and it would be nice, but don't invest too much in it since this is a somewhat temporary solution.