arran4 / golang-ical

A ICS / ICal parser and serialiser for Golang.
Apache License 2.0
310 stars 73 forks source link

Issue 97: Support for Alternative Representations #106

Closed arran4 closed 1 month ago

arran4 commented 1 month ago

See my comment: https://github.com/arran4/golang-ical/issues/97#

For details

Waiting review of original posters.

Also https://github.com/arran4/golang-ical/pull/73 is impacted sorry @ManoloTonto1 I will have to update my pr

Error additions and better matching of spec: https://icalendar.org/iCalendar-RFC-5545/3-2-1-alternate-text-representation.html

masterElmar commented 1 month ago

First Tests with Thunderbird as altrep in text/html works. Ill test some of the other altreps like chrome and plain. But many changes and a lot of good refactoring and renaming ✅ 😊

arran4 commented 1 month ago

image

Looks like I have some conflicts to resolve tomorrow too

arran4 commented 1 month ago

That was a painful conflict resolution for such a small difference. Let me know how further testing goes please.

How long should I wait for?

masterElmar commented 1 month ago

That was a painful conflict resolution for such a small difference. Let me know how further testing goes please.

How long should I wait for?

Thank you for all the effort 👍 Ill would test it the next 24h and then you could go on. As far as i tested my Google and Thunderbird cases everything passes and after import of ical looks right.

arran4 commented 1 month ago

Awesome. Thanks. I will look for a Saturday (Australian Eastern Standard time) merge.

arran4 commented 1 month ago

Are you happy to wait for the other PRs, or do you want a semantic release for these changes this weekend? (The other PRs could take until the end of the year.)

masterElmar commented 1 month ago

Are you happy to wait for the other PRs, or do you want a semantic release for these changes this weekend? (The other PRs could take until the end of the year.)

A release in the near future would be nice, because we use this library in our open source project for student schedules. The new feature with altreps for diffrent clients is very helpful in our case.

arran4 commented 1 month ago

Okay once tested, then a final test once released.

arran4 commented 1 month ago

Merged!