search

arran4 / golang-ical

A ICS / ICal parser and serialiser for Golang.
Apache License 2.0
310 stars 73 forks source link

VTodo and VJournal Missing Setters and Getters #65

Closed spslater closed 1 week ago

spslater commented 1 year ago

The VEvent component has most (all?) of the methods to be able to set and get the different parts of the component like the summary, description, start time, ect. It also has a way to create new events.

The VTodo and VJournal only have a way to serialize and load the information. (I think same is true with VBusy and VTimezone, but I don't need those for my project right now, so I haven't looked at them yet)

If these haven't been implemented yet because there hasn't been a need for it, then I will go ahead and work on adding this functionality.

arran4 commented 1 year ago

You're correct:

these haven't been implemented yet because there hasn't been a need for it

Please do, happy to accept PRs. If possible comment, but consistency with the others I think is key right now.

quite commented 11 months ago

Yeah, I began using golang-ical for a small project, and creating a VCAL with a VTODO component would be nice, and being able to set all props.

arran4 commented 11 months ago

I'm currently travelling but I will see why this has stalled in a couple weeks if not sooner.

arran4 commented 1 month ago

I believe this was partially or full resolved in: https://github.com/arran4/golang-ical/pull/90

Can you please review and let me know?

spslater commented 1 week ago

Just reviewed the current code and looks like everything has the needed setters and getters. Thanks.

Should be good to close this issue now.

arran4 commented 1 week ago

Thanks will do