search

arran4 / golang-ical

A ICS / ICal parser and serialiser for Golang.
Apache License 2.0
310 stars 73 forks source link

Fix several panics in ParseCalendar #85

Closed brackendawson closed 10 months ago

brackendawson commented 10 months ago

I was trying to Fuzz webcal-proxy but I need golang-ical to be panic free first.

arran4 commented 10 months ago

Thanks. Looks good. Running tests.

arran4 commented 10 months ago

Tests are failing for pre-fuzzing go. Perhaps use build tags?

Something like:

// +build go1.18

But that is not correct as it isn't forwards compatible I think. I rarely use go version build constraints

arran4 commented 10 months ago

Hrm.. Should modify the github workflow action to test on more recent versions of go as well.

brackendawson commented 10 months ago

Hrm.. Should modify the github workflow action to test on more recent versions of go as well.

I notice you test from 1.14 but the go directive in the mod file is 1.13.

arran4 commented 10 months ago

Cool all tests pass.

I notice you test from 1.14 but the go directive in the mod file is 1.13.

Interesting. I didn't notice. That would have happened by accident over time rather than intentional. I don't see a reason to change it right now but will accept a PR/change that pushes the matrix back.

arran4 commented 10 months ago 
% git-tag-inc release && git push --tags
Largest: v0.2.3 (51fa6f12130177fd8e6ef8e6e5fcc79e28141324)
Creating v0.2.4
warning: not sending a push certificate since the receiving end does not support --signed push
Enumerating objects: 1, done.
Counting objects: 100% (1/1), done.
Writing objects: 100% (1/1), 155 bytes | 155.00 KiB/s, done.
Total 1 (delta 0), reused 0 (delta 0), pack-reused 0
To https://github.com/arran4/golang-ical.git
 * [new tag]         v0.2.4 -> v0.2.4

Tagged to release for you