search

arranbartish / angular-cli-seed

angular2 with angular-cli
MIT License
6 stars 5 forks source link

Introduce Mocha + sinon instead of Jasmine #19

Closed arranbartish closed 7 years ago

arranbartish commented 7 years ago

Mocha + sinon seem to have better options for dealing with time and async.

arranbartish commented 7 years ago

After literally days of adding files and romoving them i've asked the wallaby Guru what i'm doing wrong in my wallaby config in wallabyjs/public#1065

arranbartish commented 7 years ago

ArtemGovorov is a legend and provided pull request #18

It seems ordering is important!

Going to merge and see if I can get any closer to making this conversion

arranbartish commented 7 years ago

The conversion is almost complete. There are issues getting the e2e to work though.

http://stackoverflow.com/questions/42839202/protractormocha-fails-suite-with-typeerror-before-browser-loads-sut

arranbartish commented 7 years ago

Looks like i'm not the only one who wants to do this angular/angular-cli#4071. Seems to be a feature request for ng test.

It would nice if angular-cli allowed you to generate the config with mocha as an alternative for both ng test and ng e2e, but I certainly get it that it's extra overhead.

arranbartish commented 7 years ago

merged as part of #24