arras-energy / gridlabd-old

HiPAS GridLAB-D is the California Energy Commission (CEC) version of GridLAB-D.
https://docs.gridlabd.us
BSD 3-Clause "New" or "Revised" License
33 stars 31 forks source link

SuperLU_MT library uses deprecated C syntax #1313

Closed dchassin closed 1 year ago

dchassin commented 1 year ago

Problem description

The following warning are issued on some platform when building superlu_mt:

third_party/superLU_MT/pdgstrf_thread_finalize.c:129:21: warning: passing arguments to 'ParallelFinalize' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
    ParallelFinalize(pxgstrf_shared);
third_party/superLU_MT/pdmemory.c:777:23: warning: a function declaration without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
    char *snode_env, *getenv();
In file included from third_party/superLU_MT/pxgstrf_synch.c:10:
third_party/superLU_MT/pdsp_defs.h:267:13: warning: a function declaration without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
extern int  ParallelFinalize ();
third_party/superLU_MT/pxgstrf_synch.c:198:5: warning: a function declaration without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
int ParallelFinalize(pxgstrf_shared_t *pxgstrf_shared)
third_party/superLU_MT/qrnzcnt.c:139:10: warning: variable 'nsuper' set but not used [-Wunused-but-set-variable]
    int  nsuper;    /* total number of fundamental supernodes in Lc */

Steps to reproduce

$ ./build.sh --clean --parallel --system

Expected behavior

No warnings should be issued.

System information

dchassin commented 1 year ago

Fixed in new gridlabd repo (v4.3.3)