search

arras-energy / gridlabd

Arras Energy simulator
https://www.arras.energy/
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

Assert doesn't use gldcore property compare #59

Open dchassin opened 4 years ago

dchassin commented 4 years ago

Problem description

The validation test for #input modify fails intermittently with the following error:

ERROR    [2020-01-01 00:00:00 UTC] : assert:1: assert failed on  test.var. +2 == +2 
ERROR    [2020-01-01 00:00:00 UTC] : commit_all() failure: object assert:1 commit failed
dchassin commented 4 years ago

Changing the variable type from double to char32 makes the test reliable. The problem remains but it's much less visible now. This problem is not the point of the test in question, so the test is fixed to focus on its purpose, and this issue remains open until asserts like the one used in this test work properly on doubles.