Remove unimplemented internal functions.

arrayfire / arrayfire-haskell

Haskell bindings to ArrayFire

http://hackage.haskell.org/package/arrayfire

BSD 3-Clause "New" or "Revised" License

59 stars 5 forks source link

Remove unimplemented internal functions. #14

Closed noughtmare closed 4 years ago

noughtmare commented 4 years ago

Running cabal test fails because the linker can't find these functions:

In Image.hsc:

af_iterative_deconv
af_iverse_deconv

In LAPACK.hsc:

af_pinverse

In Signal.hsc:

af_approx1_uniform
af_approx2_uniform

Should these functions be removed?

dmjio commented 4 years ago

@noughtmare can you confirm you're using 3.6.4. If so, then yes I can make a PR to comment them out. They might have been implemented from building off of master.

noughtmare commented 4 years ago

@dmjio Yes, I'm using 3.6.4. Interestingly, there are some comments in the higher level *.hs files about this: https://github.com/arrayfire/arrayfire-haskell/blob/65bdf727def2bef77c47786585d19ba9050bd860/src/ArrayFire/LAPACK.hs#L198 and https://github.com/arrayfire/arrayfire-haskell/blob/65bdf727def2bef77c47786585d19ba9050bd860/src/ArrayFire/Signal.hs#L561

dmjio commented 4 years ago

fftConvolve1 was commented out. I'll update the others as well. Thanks for looking into this.

dmjio commented 4 years ago

https://github.com/arrayfire/arrayfire-haskell/pull/17