search

arrayfire / forge

High Performance Visualization
226 stars 48 forks source link

support to render axes labels in scientific number format #121

Closed 9prady9 closed 7 years ago

9prady9 commented 7 years ago

Added a member function to Chart object to set number display format for axes labels.

9prady9 commented 7 years ago

Right now, the input arguments to this function are booleans. I am wondering if the inputs to setAxesLabelFormat should be an enum instead of boolean to be future proof. @arrayfire/core-devel Any ideas ?

shehzan10 commented 7 years ago

I think an enum about be better. That said, I don't know of any other widely used number formats. The only thing I can think of is if we use logarithmic charts, but even in that case, the numbering format will be one of these 2.

umar456 commented 7 years ago

Enums would be ideal. It would make the code more readable.

9prady9 commented 7 years ago

@shehzan10 pls check now.

9prady9 commented 7 years ago

@shehzan10 You can review it now. Auto-switch to scientific notation is now enabled.

9prady9 commented 7 years ago

Shall be merged through https://github.com/arrayfire/forge/pull/129