search

arrayfire / forge

High Performance Visualization
224 stars 48 forks source link

Use glfw find_package #132

Closed pfultz2 closed 7 years ago

pfultz2 commented 7 years ago

This uses glfw's cmake package config, which will build with its exported target. This help build properly when glfw is built statically.

pavanky commented 7 years ago

@pfultz2 can you check which version of cmake the glfw package was introduced ?

9prady9 commented 7 years ago

@pfultz2 Also, did you test this change on Windows ?

pfultz2 commented 7 years ago

can you check which version of cmake the glfw package was introduced ?

The glfw3 has been there since 3.1, before that the package was called just glfw.

pfultz2 commented 7 years ago

Also, did you test this change on Windows ?

I did check it on windows and it works for windows as well. I am not sure why it wouldn't.

9prady9 commented 7 years ago

Can you please reopen this to be merged into devel. The target branch for new merges is always devel not master.

pavanky commented 7 years ago

@9prady9 just cherry pick into devel

9prady9 commented 7 years ago

@pavanky The reason i asked him to do it is CMakeLists.txt under src/backend/opengl is different from the one in master. @pfultz2 I have taken care it for now. Please do open PR's with devel as target branch from now.