search

arreason / CategoryLearning

Where Category Theory meets Machine Learning
1 stars 0 forks source link

Data wn18 #25

Closed igorgarbuz closed 3 years ago

igorgarbuz commented 4 years ago

PR intended for the very 1st review. Modifications are planned according to ongoing changes regarding composite arrows computation. Any kind of feedback is welcome.

Previsou commented 4 years ago

In addition, you have lots of pylint warnings, cleanup. While the whole code is not 100% clean, we strive to have as little as possible such linting errors.

You can have a look with pylint -f colorized (catlearn|scripts|tests)

Previsou commented 3 years ago

@igorgarbuz would you mind trying to clean up the branch? Seeing Chris's and my commits in your branch makes everything harder to review, and you would conflict anyway

igorgarbuz commented 3 years ago

Will squash it.

@igorgarbuz would you mind trying to clean up the branch? Seeing Chris's and my commits in your branch makes everything harder to review, and you would conflict anyway