Recat ml 3 core first version

arreason / CategoryLearning

Where Category Theory meets Machine Learning

1 stars 0 forks source link

Recat ml 3 core first version #6

Closed Kuraao closed 5 years ago

Kuraao commented 5 years ago

First Version of the new Core.

Covers evaluation and training regimen; not composites proposals.

Previsou commented 5 years ago

I am almost done here. Just need to wrap my head around the remap_subproba function

Kuraao commented 5 years ago

Adressed most comments, except:

Having CompositeArrow and CompositionGraph in a different file (doing that now)
Comments about redefinition of getitem. Looking into an other way of doing (by not inheriting the CompositionGraph class but have it as an attribute. This will be less messy)
the 2 comments you tagged as minor

Since this is quite many changes I pushed what was already done.

Kuraao commented 5 years ago

Proposed a new version of RelationCache not inheriting from CompositionGraph. I'll leave you looking at it and telling me what you think. The last few comments you left after second push are not taken into account yet.