arrenglover / openfabmap

Open-source C++ code for the FAB-MAP visual place recognition algorithm
Other
221 stars 68 forks source link

Refactoring inference and separating classes. #10

Closed kmactavish closed 9 years ago

kmactavish commented 9 years ago

Note: I wanted to get this all pulled in at once, so the refactoring and file-splitting are lumped together. See the refactoring without the file-splitting. See the file-splitting only.

This pull request accomplishes the following

P.S. Sorry for the giant pull request :(.

arrenglover commented 9 years ago

Overall the changes look good. I also noticed that you have renamed some types as CV_EXPORTS, is this towards contributing to openCV 3.0? Thanks for the patch :)

kmactavish commented 9 years ago

I'll probably be a few weeks before I can come back to this (IROS, etc), but I'll eventually get around to addressing the comments with a new commit. :)