arrikto / oidc-authservice

This is a fork/refactoring of the ajmyyra/ambassador-auth-oidc project
MIT License
87 stars 66 forks source link

Remove CORS middleware #58

Open yanniszark opened 3 years ago

yanniszark commented 3 years ago

Description of your changes:

The AuthService used a CORS middleware as a remnant of the original fork: https://github.com/ajmyyra/ambassador-auth-oidc/commit/43dd5ae57de2e4bdfc786fc35dd754ffa508e357

The CORS middleware permits requests with certain default methods and headers. However, since the default answer is 200, what it actually does is proxy the CORS requests for those methods. I don't like the fact that we don't set the response code explicitly. We should either remove this middleware or document its use clearly.

Requirements: