search

arrikto / oidc-authservice

This is a fork/refactoring of the ajmyyra/ambassador-auth-oidc project
MIT License
87 stars 66 forks source link

Fix some typos in the README #59

Closed apyrgio closed 1 year ago

athamark commented 1 year ago

The proposed fixes make sense. I would also include a fix for the KUBERNETE_AUTHN_ENABLED description in the README.md. We have not used the proper name in the description:

| KUBERNETES_AUTHN_ENABLED | true | Set Kubernetes_AUTHN_ENABLED to false to disable the Kubernetes authentication method. |

Line: https://github.com/arrikto/oidc-authservice/blob/master/README.md?plain=1#L136 Commit Hash that introduced this discrepancy: 2a0b0b4f00b5d30ecc8e07ca34bf197ee8c96809 Proposed fix It should be all capitals (KUBERNETES_AUTHN_ENABLED). I will make a fixup for this.

The rest LGTM!