search

arriven / db1000n

MIT License
1.17k stars 201 forks source link

Added proxy URL validation and socks5 support for rawnet job type (#279) #381

Closed lollypot closed 2 years ago

lollypot commented 2 years ago

See description of CR here #279

It's still not work for udp type jobs "msg":"error running job","error":"socks connect udp 172.17.0.1:9150->1.2.3.4:53: network not implemented" because socks5 library is not support udp for now. But I am decided to leave it as is because when you will run it through proxy - you expect that it it should go through proxy and, probably, you don't want to get abuse messages to yours workloads.

arriven commented 2 years ago

Btw, would it be ok to you to add this proxy to slowloris as well? Can be a separate PR

arriven commented 2 years ago

And one more thing - can we also expose proxy settings to the job config so that it's similar to how it's done in http jobs?

arriven commented 2 years ago

@lollypot hope you don't mind me reimplementing this with my comments in #384

lollypot commented 2 years ago

@Arriven Yes. Thank you very much - you will do it better. of course :). Sorry that I not respond in shorter time. But I have one comment: https://github.com/Arriven/db1000n/pull/381#discussion_r830877783 . What do you think?