search

arrobalytics / django-ledger

Django Ledger is a double entry accounting system built on the Django Web Framework.
https://www.djangoledger.com
GNU General Public License v3.0
1.03k stars 226 forks source link

Fix error upon viewing Estimate Detail #131

Closed Lianto2020 closed 1 year ago

Lianto2020 commented 1 year ago

1) On "Estimates & Contracts" list page, the Action->Detail button will show error 'Estimate xxx is not a Contract.' It happens when Estimate status is one of Draft/Canceled/In Review/Void. This exception is thrown from Estimate model's get_contract_summary() method if the object is not a contract. To avoid this I add contract status checking before get_contract_summary() is called.

2) Add missing '()' in the PurchaseOrderModel's object manager statement.

Lianto2020 commented 1 year ago

Commit v0.5.2.14 (Feb 15, 23) already fix these problems so i cancel my pull request.