Make memoization compatible with MPP

arrow-kt / arrow-core

Λrrow Core is part of Λrrow, a functional companion to Kotlin's Standard Library

http://arrow-kt.io

Other

81 stars 30 forks source link

Make memoization compatible with MPP #331

Closed aballano closed 3 years ago

aballano commented 3 years ago

Replace ConcurrentHashMap impl by atomic to be able to work in MPP

aballano commented 3 years ago

@rachelcarmena @nomisRev Seems this PR is failing for arrow-fx due to test flakiness(?) or might have my changes affected that?

nomisRev commented 3 years ago

@aballano seems to be the case of something flaky in Arrow Fx and Arrow Fx RxJava which are both deprecated so not very concerning but I've never seen the flaky test in Arrow Fx RxJava.

I restarted the build. Have you seen this multiple times on this PR?

aballano commented 3 years ago

@nomisRev Yes, the previous build after merging master also failed due to failed test for Bracket in the stream package