Implement ParTupledN arity 4

arrow-kt / arrow-fx

Λrrow Fx is part of Λrrow, a functional companion to Kotlin's Standard Library

http://arrow-kt.io

Other

64 stars 15 forks source link

Implement ParTupledN arity 4 #370

Closed LordRaydenMK closed 3 years ago

LordRaydenMK commented 3 years ago

Issue

Fixes https://github.com/arrow-kt/arrow-fx/issues/347 (I hope, assuming the word Par is missing in the title cc @nomisRev )

Status

READY

Description

ParTupledN arity 4 based on the arity 3 impl I took the liberty to create a parTupledN package in the tests (following the approach of parMapN) and created a separate spec just for Arity4 Also I am using Tuple4 from arrow core since Kotlin doesn't have an equivalent AFIK

Todos

[x] Tests
[x] Documentation

Related PRs

None

LordRaydenMK commented 3 years ago

arrow.fx.coroutines.parTupledN.ParTupled4Test > ParTupledN 4 cancels losers if a failure occurs in one of the tasks FAILED TimeoutException(duration=600000) at io.kotest.engine.ExecutorExecutionContext$executeWithTimeoutInterruption$$inlined$suspendCoroutine$lambda$1.run(ExecutorExecutionContext.kt:41)

looks like flaky tests. Can someone re-trigger please?

LordRaydenMK commented 3 years ago

arrow.fx.coroutines.parTupledN.ParTupled4Test > ParTupledN 4 cancels losers if a failure occurs in one of the tasks FAILED TimeoutException(duration=600000) at io.kotest.engine.ExecutorExecutionContext$executeWithTimeoutInterruption$$inlined$suspendCoroutine$lambda$1.run(ExecutorExecutionContext.kt:41)

looks like flaky tests. Can someone re-trigger please?

I stand corrected, the test was wrong. Fixed now.