Closed nomisRev closed 3 years ago
Thanks for the great review @aballano!
@aballano applied review suggestions. The only thing I can think of to improve the nanos
situation is to make the API use milliseconds
instead which I guess is more common in public APIs. kotlin.time.*
should just go stable 😫
Issue
arrow.fx.coroutines.repeat
conflicts withkotlin.repeat
which IDEA always auto-suggests and prefers overarrow.fx.coroutines.repeat
sincekotlin
is a special case.Status
READY
Description
Since
arrow.fx.coroutines.repeat
conflicts withkotlin.repeat
which IDEA always auto-suggests and prefers overarrow.fx.coroutines.repeat
sincekotlin
is a special case, we need an alternative API forrepeat
(andretry
) so this is now defined as a method onSchedule
itself. Sinceretry
's Schedule has as input type ofThrowable
it's defined as a extension function onSchedule
instead of a top-level function that takes aSchedule
.Since Arrow Fx Coroutines Duration is deprecated in favor of Kotlin Time's Duration we need to provide alternative APIs to deprecate towards. This PR adds these alternative methods, and the required deprecation messages.
Related PRs
366