arrow-kt / suspendapp

Reason about resource-safety in the same way you reason about Structured Concurrency with SuspendApp!
https://arrow-kt.github.io/suspendapp/
Apache License 2.0
74 stars 4 forks source link

Add server constructor with ApplicationEngineEnvironment #119

Closed Atternatt closed 4 months ago

Atternatt commented 4 months ago

This PR tries to solve the need for ssl configuration (or any other that can by done through ApplicationEngineEnvironment) in Ktor Server using suspendapp

nomisRev commented 4 months ago

@Atternatt, I think you were missing a apiDump and perhaps a spotlessApply.

Atternatt commented 4 months ago

@nomisRev sure, I'm in a road trip and I'm developing in the free time while not driving. will do it as soon as I can reach the laptop 😁

nomisRev commented 4 months ago

@Atternatt whenever I comment it's not to rush you 😅 No worries about that! Be safe, and enjoy your road trip! 🌴

Atternatt commented 4 months ago

I ran both :)