arrow-py / arrow

🏹 Better dates & times for Python
https://arrow.readthedocs.io
Apache License 2.0
8.7k stars 673 forks source link

Refactored Arabic Locale For Dehumanize Support #1028

Closed anishnya closed 3 years ago

anishnya commented 3 years ago

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Refactor of Arabic Locale for future dehumanize support. The main reason for this change is that we need a way to convey the actual delta some of those strings represent. Rather than creating a look-up table, or some kind of translation logic, I think it is easier to just have the key be the string representation of an integer. This way, dehumanize call easily interpret this. This will make more sense, when I push the actual dehumanize update PR (after the backlog of locale refactor PRs get merged in :) ).

codecov[bot] commented 3 years ago

Codecov Report

Merging #1028 (8f4e1b6) into master (6b9e427) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1028   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2161      2161           
  Branches       340       340           
=========================================
  Hits          2161      2161           
Impacted Files Coverage Δ
arrow/locales.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6b9e427...8f4e1b6. Read the comment docs.