arrow-py / arrow

🏹 Better dates & times for Python
https://arrow.readthedocs.io
Apache License 2.0
8.7k stars 673 forks source link

Fixing plural of years and days in Hebrew #1042

Closed guyernest closed 3 years ago

guyernest commented 3 years ago

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

guyernest commented 3 years ago

Thank you for your attention and I apologize for missing these tests failures. I've fixed the format, added a couple of tests, and verified they are passing now.

codecov[bot] commented 3 years ago

Codecov Report

Merging #1042 (70a0310) into master (a4f1797) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1042   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2166      2168    +2     
  Branches       344       345    +1     
=========================================
+ Hits          2166      2168    +2     
Impacted Files Coverage Δ
arrow/locales.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a4f1797...70a0310. Read the comment docs.

guyernest commented 3 years ago

I didn't notice any change in the files, however, it might be some whitespace characters or new lines that I don't see.

I hope now it will pass the workflow smoothly