arrow-py / arrow

🏹 Better dates & times for Python
https://arrow.readthedocs.io
Apache License 2.0
8.7k stars 673 forks source link

Expand Three Locales' Test Cases #1076

Closed kaiyang-code closed 2 years ago

kaiyang-code commented 2 years ago

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

add more test cases for locales based on #1022 Timeframe testing for multiple variations expanded for the following locales (including relative):

ChineseCN ChineseTW HongKong

codecov[bot] commented 2 years ago

Codecov Report

Merging #1076 (adc990c) into master (fecbada) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1076   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2237      2237           
  Branches       439       439           
=========================================
  Hits          2237      2237           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fecbada...adc990c. Read the comment docs.

anishnya commented 2 years ago

Hey @kaiyang-code, try running make lint on your machine and push the changes. They should pass our checks soon after. Let me know if you need any further assistance.