arrow-py / arrow

🏹 Better dates & times for Python

https://arrow.readthedocs.io

Apache License 2.0

8.64k stars 667 forks source link

Add Georgian locale #1088

Closed cyriaka90 closed 2 years ago

cyriaka90 commented 2 years ago

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

[x] 🧪 Added tests for changed code.
[x] 🛠️ All tests pass when run locally (run tox or make test to find out!).
[x] 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
[ ] 📚 Updated documentation for changed code.
[x] ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Adds Georgian to arrow locales. :)

codecov[bot] commented 2 years ago

Codecov Report

Merging #1088 (73cf4ac) into master (cdc8d33) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1088   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2243      2253   +10     
  Branches       439       440    +1     
=========================================
+ Hits          2243      2253   +10

Impacted Files	Coverage Δ
arrow/constants.py	`100.00% <ø> (ø)`
arrow/locales.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cdc8d33...73cf4ac. Read the comment docs.

cyriaka90 commented 2 years ago

I don't know why tests / windows-latest (3.7) fails. :/ tox && tox -e lint,docssucceeded, when I ran it locally.

anishnya commented 2 years ago

Hey @cyriaka90, sorry for just seeing this now. @jadchaar, @systemcatch , @krisfremen any reason why we might be failing only specifically on the Windows runner? I vaguely remember us having a runner issue like this on an earlier PR a while back?

Edit: It looks like this was resolved somehow after we pulled in some updates from master. I'm not too sure why though.

cyriaka90 commented 2 years ago

Thanks! Glad that it was resolved!