arrow-py / arrow

🏹 Better dates & times for Python

https://arrow.readthedocs.io

Apache License 2.0

8.64k stars 667 forks source link

Add Laotian locale #1105

Closed cyriaka90 closed 2 years ago

cyriaka90 commented 2 years ago

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

[x] 🧪 Added tests for changed code.
[x] 🛠️ All tests pass when run locally (run tox or make test to find out!).
[x] 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
[ ] 📚 Updated documentation for changed code.
[x] ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Adds Laotian locale. (Wasn't sure if it should be added to the lists in constants.py and test_arrow.py.)

codecov[bot] commented 2 years ago

Codecov Report

Merging #1105 (f74d70f) into master (1904804) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1105   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2281      2305   +24     
  Branches       444       447    +3     
=========================================
+ Hits          2281      2305   +24

Impacted Files	Coverage Δ
arrow/constants.py	`100.00% <ø> (ø)`
arrow/locales.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1904804...f74d70f. Read the comment docs.

cyriaka90 commented 2 years ago

There is an issue with the code coverage, that seems to be a recurring thing: https://github.com/arrow-py/arrow/pull/1096#issuecomment-1072355100 Any news here? :)

Also there seems to be an issue with click while running the linter: ImportError: cannot import name '_unicodefun' from 'click' Anything that can be done about that?

anishnya commented 2 years ago

There is an issue with the code coverage, that seems to be a recurring thing: https://github.com/arrow-py/arrow/pull/1096#issuecomment-1072355100 Any news here? :)

Also there seems to be an issue with click while running the linter: ImportError: cannot import name '_unicodefun' from 'click' Anything that can be done about that?

It appears to be a non-deterministic issue. We're still digging trying to find a solution.

anishnya commented 2 years ago

There is an issue with the code coverage, that seems to be a recurring thing: #1096 (comment) Any news here? :) Also there seems to be an issue with click while running the linter: ImportError: cannot import name '_unicodefun' from 'click' Anything that can be done about that?

It appears to be a non-deterministic issue. We're still digging trying to find a solution.

This is now fixed. The PR LGTM and thank you @cyriaka90 for another locale contribution :).