arrow-py / arrow

🏹 Better dates & times for Python
https://arrow.readthedocs.io
Apache License 2.0
8.63k stars 669 forks source link

Proposal to change certain Thai translations in Locale #1127

Open sanittawan opened 1 year ago

sanittawan commented 1 year ago

Hello! I'm a native Thai speaker who happened to stumble upon your project. I would love to propose the following changes as detailed in the comments.

    past = "{0} ที่ผ่านมา" # --> The present translation is fine, but it sounds more natural to use ที่แล้ว. 
                             # For example, if I use this library to print out the last check point, ที่แล้ว is more suitable

    timeframes = {
        "now": "ขณะนี้",
        "second": "วินาที", # --> this should be changed to "1 วินาที"
        "seconds": "{0} ไม่กี่วินาที", # --> this should be changed to "{0} วินาที"
        "minute": "1 นาที",
        "minutes": "{0} นาที",
        "hour": "1 ชั่วโมง",
        "hours": "{0} ชั่วโมง",
        "day": "1 วัน",
        "days": "{0} วัน",
        "month": "1 เดือน",
        "months": "{0} เดือน",
        "year": "1 ปี",
        "years": "{0} ปี",
    }

I'm happy to make these minor changes if you see fit and submit a pull request. I also saw that you are looking to improve test cases in various languages. I am happy to write some tests for Thai, but I need a bit more time to familiarize myself with the library. I'm fairly new to open source contribution as well, but would love to learn and do more.

krisfremen commented 1 year ago

Hey @sanittawan,

Yes, please, go ahead and make a PR if you can.

We welcome all contributions!

sanittawan commented 1 year ago

Thanks @krisfremen! I will get to it later in the week and will send a PR.