Closed gruebel closed 1 year ago
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:
Coverage data is based on head (
f5e0476
) compared to base (8cac5fa
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hehe, yeah, but more than just mypy here. I will take a deeper look tonight.
@krisfremen yeah sorry ๐ I started a small and then more and more small changes were added. I can also split the PR, if you feel more comfortable with it.
@gruebel yeah, i don't mind the PR as is, but just for clarity, but let's do the mypy stuff in this PR and split out the version bumps for the rest of the precommit and the GitHub actions in another PR.
Otherwise looks great! Thanks for contributing!
@krisfremen thanks ๐ป
As suggested I split this PR into 2.
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
tox
ormake test
to find out!).tox -e lint
ormake lint
to find out!).master
branch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
mypy
to the newest version, because it has some nice improvementsmypy
found a typing issue with_ordinal_number
forBengaliLocale
, which is correct, because it would returnNone
if a negative number is passed in. This behaviour doesn't fit other locales, likeOdiaLocale
andTamilLocale
one. I hope I made the right call here to change the return value to an empty stringtype: ignore
comments to not automatically ignore other typing issue in the same linemypy
config to show the error code, when there is a typing issue and do it pretty ๐ that's how it would look like