arrow-py / arrow

๐Ÿน Better dates & times for Python
https://arrow.readthedocs.io
Apache License 2.0
8.63k stars 669 forks source link

Upgrade mypy #1129

Closed gruebel closed 1 year ago

gruebel commented 1 year ago

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

codecov[bot] commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (f5e0476) compared to base (8cac5fa). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1129 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 9 9 Lines 2318 2319 +1 Branches 492 492 ========================================= + Hits 2318 2319 +1 ``` | [Impacted Files](https://codecov.io/gh/arrow-py/arrow/pull/1129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arrow-py) | Coverage ฮ” | | |---|---|---| | [arrow/arrow.py](https://codecov.io/gh/arrow-py/arrow/pull/1129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arrow-py#diff-YXJyb3cvYXJyb3cucHk=) | `100.00% <100.00%> (รธ)` | | | [arrow/locales.py](https://codecov.io/gh/arrow-py/arrow/pull/1129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arrow-py#diff-YXJyb3cvbG9jYWxlcy5weQ==) | `100.00% <100.00%> (รธ)` | | | [arrow/parser.py](https://codecov.io/gh/arrow-py/arrow/pull/1129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arrow-py#diff-YXJyb3cvcGFyc2VyLnB5) | `100.00% <100.00%> (รธ)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arrow-py). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arrow-py)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

krisfremen commented 1 year ago

Hehe, yeah, but more than just mypy here. I will take a deeper look tonight.

gruebel commented 1 year ago

@krisfremen yeah sorry ๐Ÿ˜… I started a small and then more and more small changes were added. I can also split the PR, if you feel more comfortable with it.

krisfremen commented 1 year ago

@gruebel yeah, i don't mind the PR as is, but just for clarity, but let's do the mypy stuff in this PR and split out the version bumps for the rest of the precommit and the GitHub actions in another PR.

Otherwise looks great! Thanks for contributing!

gruebel commented 1 year ago

@krisfremen thanks ๐Ÿป

As suggested I split this PR into 2.