arrow-py / arrow

🏹 Better dates & times for Python
https://arrow.readthedocs.io
Apache License 2.0
8.63k stars 669 forks source link

Add fold kwarg for arrow.get #1139

Open nik-k11 opened 1 year ago

nik-k11 commented 1 year ago

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Also please note the fold documentation in ArrowFactory.get. Basically, I only relay the fold kwarg into Arrow.fromdatetime and Arrow.__init__ calls.

Doesn't seem like using fold for timestamps, now calls or dates makes sense. But maybe it should be passed. What do you think?

Closes: #872

codecov[bot] commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (4d68b9c) compared to base (74a759b). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1139 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 9 9 Lines 2319 2325 +6 Branches 492 495 +3 ========================================= + Hits 2319 2325 +6 ``` | [Impacted Files](https://codecov.io/gh/arrow-py/arrow/pull/1139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arrow-py) | Coverage Δ | | |---|---|---| | [arrow/api.py](https://codecov.io/gh/arrow-py/arrow/pull/1139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arrow-py#diff-YXJyb3cvYXBpLnB5) | `100.00% <ø> (ø)` | | | [arrow/arrow.py](https://codecov.io/gh/arrow-py/arrow/pull/1139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arrow-py#diff-YXJyb3cvYXJyb3cucHk=) | `100.00% <100.00%> (ø)` | | | [arrow/factory.py](https://codecov.io/gh/arrow-py/arrow/pull/1139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arrow-py#diff-YXJyb3cvZmFjdG9yeS5weQ==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arrow-py). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arrow-py)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.