Open nik-k11 opened 1 year ago
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:
Coverage data is based on head (
4d68b9c
) compared to base (74a759b
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
tox
ormake test
to find out!).tox -e lint
ormake lint
to find out!).master
branch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
fold
kwarg forarrow.get
.getattr
since Python 2.7/3.5 support is dropped.Arrow.__init__
per this discussion.Also please note the
fold
documentation inArrowFactory.get
. Basically, I only relay thefold
kwarg intoArrow.fromdatetime
andArrow.__init__
calls.Doesn't seem like using
fold
for timestamps,now
calls or dates makes sense. But maybe it should be passed. What do you think?Closes: #872