arrow-py / arrow

🏹 Better dates & times for Python
https://arrow.readthedocs.io
Apache License 2.0
8.63k stars 669 forks source link

pylint fixes #1141

Closed marksmayo closed 9 months ago

marksmayo commented 1 year ago

some tidyups for pylint

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Some tidyups with pylint, and black also fixed some stuff on pre-commits.

codecov[bot] commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (15fac47) compared to base (74a759b). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1141 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 9 9 Lines 2319 2319 Branches 492 492 ========================================= Hits 2319 2319 ``` | [Impacted Files](https://codecov.io/gh/arrow-py/arrow/pull/1141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arrow-py) | Coverage Δ | | |---|---|---| | [arrow/arrow.py](https://codecov.io/gh/arrow-py/arrow/pull/1141/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arrow-py#diff-YXJyb3cvYXJyb3cucHk=) | `100.00% <100.00%> (ø)` | | | [arrow/factory.py](https://codecov.io/gh/arrow-py/arrow/pull/1141/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arrow-py#diff-YXJyb3cvZmFjdG9yeS5weQ==) | `100.00% <100.00%> (ø)` | | | [arrow/locales.py](https://codecov.io/gh/arrow-py/arrow/pull/1141/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arrow-py#diff-YXJyb3cvbG9jYWxlcy5weQ==) | `100.00% <100.00%> (ø)` | | | [arrow/util.py](https://codecov.io/gh/arrow-py/arrow/pull/1141/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arrow-py#diff-YXJyb3cvdXRpbC5weQ==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arrow-py). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arrow-py)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jadchaar commented 9 months ago

Hi @marksmayo thanks for the contribution. I am catching up with PRs and this PR seems to be conflicting with the current master branch. Mind getting it up to date with the latest master? Linting should be passing after a few fixes I made a few weeks ago, so please do re-open once conflicts are fixed.