arrow-py / arrow

🏹 Better dates & times for Python
https://arrow.readthedocs.io
Apache License 2.0
8.73k stars 684 forks source link

Don't force requirement on types-python-dateutil #1169

Closed mredaelli closed 3 months ago

mredaelli commented 10 months ago

Feature Request

A project I work on follows the usual pattern of having two requirements file, one for production environments and one for development, compiled by pip-tools.

I just noticed that arrow adds the types-python-dateutil package to my prod requirements.txt.

Since typing information should not be necessary at runtime, I think the installation of that package should be left to the user who wants it.

bnavigator commented 10 months ago

As a contributor to the maintenance of the openSUSE Tumbleweed Linux Python Stack, I wholeheartedly agree.

https://build.opensuse.org/request/show/1138316

sanderr commented 8 months ago

I also feel like this should be a development package. Perhaps it can be exposed as an optional extra arrow[dev] or arrow[types]? This way you can still make abstraction of your typing requirements for library users, while keeping it contained to those that specifically request it.

Lit37 commented 5 months ago

Feature Request

A project I work on follows the usual pattern of having two requirements file, one for production environments and one for development, compiled by pip-tools.

I just noticed that arrow adds the types-python-dateutil package to my prod requirements.txt.

Since typing information should not be necessary at runtime, I think the installation of that package should be left to the user who wants it.

I also feel like this should be a development package. Perhaps it can be exposed as an optional extra arrow[dev] or arrow[types]? This way you can still make abstraction of your typing requirements for library users, while keeping it contained to those that specifically request it.

jadchaar commented 3 months ago

Fixed by https://github.com/arrow-py/arrow/pull/1183