arrow-py / arrow

๐Ÿน Better dates & times for Python
https://arrow.readthedocs.io
Apache License 2.0
8.71k stars 673 forks source link

Adding trunc to delta before passing to _format_timeframe. #790

Closed krisfremen closed 4 years ago

krisfremen commented 4 years ago

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Related to #789

krisfremen commented 4 years ago

Currently breaking some tests for granularity due to expectation of floats for some comparisons.

jadchaar commented 4 years ago

Any progress on this @krisfremen?

jadchaar commented 4 years ago

Closing this for now to clear up PRs, feel free to re-open it if you make new progress.