Closed pedroma closed 4 years ago
Hi @pedroma, thank you for the PR. I see that there are similar issues with day_names
and day_abbreviations
, maybe you can take a look at them as well. The Brazilian locale inherits from the Portuguese locale so there should be no need for duplication for items that are identical.
Hey @systemcatch. No problem. I'll look into it right now.
Updated the locale. Let me know what you think.
Hey @pedroma sorry I don't see the test?
So sorry. I forgot to push ๐ . All done now.
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
tox
ormake test
to find out!).tox -e lint
ormake lint
to find out!).master
branch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
This PR fixes the Portuguese locales values. They should essentially be the same as the Brasilian ones. Also fixed capitalization. We use month name with caps in Portugal.
Thanks.