arrow-py / arrow

๐Ÿน Better dates & times for Python
https://arrow.readthedocs.io
Apache License 2.0
8.71k stars 673 forks source link

Fix Portuguese locale capitalization #793

Closed pedroma closed 4 years ago

pedroma commented 4 years ago

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

This PR fixes the Portuguese locales values. They should essentially be the same as the Brasilian ones. Also fixed capitalization. We use month name with caps in Portugal.

Thanks.

systemcatch commented 4 years ago

Hi @pedroma, thank you for the PR. I see that there are similar issues with day_names and day_abbreviations, maybe you can take a look at them as well. The Brazilian locale inherits from the Portuguese locale so there should be no need for duplication for items that are identical.

pedroma commented 4 years ago

Hey @systemcatch. No problem. I'll look into it right now.

pedroma commented 4 years ago

Updated the locale. Let me know what you think.

systemcatch commented 4 years ago

Hey @pedroma sorry I don't see the test?

pedroma commented 4 years ago

So sorry. I forgot to push ๐Ÿ˜„ . All done now.