Closed yammesicka closed 4 years ago
Merging #794 into master will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #794 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1678 1713 +35
Branches 289 295 +6
=========================================
+ Hits 1678 1713 +35
Impacted Files | Coverage Δ | |
---|---|---|
arrow/locales.py | 100.00% <100.00%> (ø) |
|
arrow/arrow.py | 100.00% <0.00%> (ø) |
|
arrow/parser.py | 100.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b8a6011...46eaaf0. Read the comment docs.
Sure, done.
There is now support for every edge-case I can think about, and probably more tests than in any other language :)
Very nice!
Toda rabah @yammesicka!
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
tox
ormake test
to find out!).tox -e lint
ormake lint
to find out!).master
branch.Description of Changes
Add Hebrew translation for "weeks". Currently I catch the ValueError in my codebase to prevent arrow from crashing when trying to humanize weeks :)