arrow-py / arrow

🏹 Better dates & times for Python
https://arrow.readthedocs.io
Apache License 2.0
8.71k stars 673 forks source link

Add weeks translation for Hebrew #794

Closed yammesicka closed 4 years ago

yammesicka commented 4 years ago

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

Description of Changes

Add Hebrew translation for "weeks". Currently I catch the ValueError in my codebase to prevent arrow from crashing when trying to humanize weeks :)

codecov-commenter commented 4 years ago

Codecov Report

Merging #794 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #794   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1678      1713   +35     
  Branches       289       295    +6     
=========================================
+ Hits          1678      1713   +35     
Impacted Files Coverage Δ
arrow/locales.py 100.00% <100.00%> (ø)
arrow/arrow.py 100.00% <0.00%> (ø)
arrow/parser.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b8a6011...46eaaf0. Read the comment docs.

yammesicka commented 4 years ago

Sure, done.

yammesicka commented 4 years ago

There is now support for every edge-case I can think about, and probably more tests than in any other language :)

krisfremen commented 4 years ago

Very nice!

Toda rabah @yammesicka!