arrow-py / arrow

🏹 Better dates & times for Python

https://arrow.readthedocs.io

Apache License 2.0

8.71k stars 673 forks source link

Improve Macedonian(MK) locale #799

Closed krisfremen closed 4 years ago

krisfremen commented 4 years ago

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

[x] 🧪 Added tests for changed code.
[x] 🛠️ All tests pass when run locally (run tox or make test to find out!).
[x] 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
[ ] 📚 Updated documentation for changed code.
[x] ⏩ Code is up-to-date with the master branch.

Description of Changes

Hello,

This PR consists of the following changes to the Macedonian locale:

Adding weeks.
Fix singular second.
Adding Slavic handling of seconds.
Of course, tests to back up the above and improvements to them.

codecov-commenter commented 4 years ago

Codecov Report

Merging #799 into master will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #799   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1713      1713           
  Branches       295       295           
=========================================
  Hits          1713      1713

Impacted Files	Coverage Δ
arrow/locales.py	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7a5676...09508f1. Read the comment docs.

jadchaar commented 4 years ago

@krisfremen can you merge in master and re-run the tests? Hopefully CI cooperates. https://github.com/crsmithdev/arrow/pull/805 might help alleviate this bug we are seeing in the tests.