Closed comfuture closed 4 years ago
Merging #804 into master will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #804 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1740 1757 +17
Branches 295 300 +5
=========================================
+ Hits 1740 1757 +17
Impacted Files | Coverage Δ | |
---|---|---|
arrow/locales.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0a37fa5...3701aca. Read the comment docs.
@krisfremen Thank you for your kind review of my clumsy contributions. I just improved the code by realizing where I was misunderstanding the behavior of locale handling internal methods.
In addition, I added special Korean date/year frame expression. Although there is a feeling of excessiveness compared to other locales, the expressions commonly used in Windows and OS X.
I'll leave it for @krisfremen to approve but I'm happy with the PR.
It fixes #808 that weeks timeframe can not be formatted in korean. And it also adds special plurlized words in korean.
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
tox
ormake test
to find out!).tox -e lint
ormake lint
to find out!).master
branch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
Related: https://github.com/crsmithdev/arrow/issues/803 Closes: #803