arrow-py / arrow

🏹 Better dates & times for Python
https://arrow.readthedocs.io
Apache License 2.0
8.71k stars 673 forks source link

Include day and month abbreviations for Catalan #853

Closed NestorTejero closed 4 years ago

NestorTejero commented 4 years ago

Sources:

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

codecov[bot] commented 4 years ago

Codecov Report

Merging #853 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #853   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines         1808      1808           
  Branches       312       312           
=========================================
  Hits          1808      1808           
Impacted Files Coverage Δ
arrow/locales.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da6ed8c...d6ef61a. Read the comment docs.

jadchaar commented 4 years ago

Seems like the title casing is in fact intentional: https://wordinfo.info/unit/3230. Should be good to merge this once CI passes.

NestorTejero commented 4 years ago

Looks good, but was the removal of title casing intentional @NestorTejero?

yes! In Catalan, month and week day names are not capitalized (unless in the beginning of a sentence). I included the sources in my first comment. Thanks for cross checking.